Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for "browser" field, making inclusion in the browser more robust. #30

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

sramam
Copy link
Contributor

@sramam sramam commented Nov 29, 2016

Adding the "browser" field to package.json.
For details, see: https://github.com/defunctzombie/package-browser-field-spec

Useful when one is not using bower to install this package. Atleast webpack seems to pick this up without issue.
Webpack seems to support it - seems like an elegant solution for mixed usage libraries.

Seems to be a better solution than #27 #27

Adding the "browser" field to package.json.
For details, see: https://github.com/defunctzombie/package-browser-field-spec

Useful when one is not using bower to install this package. Atleast webpack seems to pick this up without issue.
Webpack seems to support it - seems like an elegant solution for mixed usage libraries. 

Seems to be a better solution than APIDevTools#27 APIDevTools#27
@sramam sramam changed the title adding support for "browser" field, making this more robust when including in the browser. adding support for "browser" field, making inclusion in the browser more robust. Nov 29, 2016
@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage remained the same at 94.653% when pulling 8280727 on sramam:master into 8154cf1 on BigstickCarpet:master.

@JamesMessinger JamesMessinger merged commit 0f2405f into APIDevTools:master Dec 4, 2016
@JamesMessinger
Copy link
Member

@sramam - Thanks for the PR! much appreciated

@JamesMessinger
Copy link
Member

I just released v3.2.0, which includes this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants